Add is_vpn attribute to session object #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
mikeradka
added
enhancement
mikeradka
requested review from
Aniak5,
pagbabian-splunk,
floydtree and
adplotzk
Aniak5
reviewed
Jan 9, 2024
Signed-off-by: Michael Radka <[email protected]>
floydtree
approved these changes
Jan 9, 2024
irakledibm
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
N/A
Description of changes:
This PR adds an
is_vpnattribute to thesessionobject. This is a useful way to signify that a given session in any event class is a vpn session - particularly this is useful for security analysts and detection engineers, without the need for a yet-another-profile.